Re: [PATCH v4 3/4] Style fixes
From: Antonio Ospite <hidden>
Date: 2014-07-14 10:20:05
Also in:
lkml
On Sun, 13 Jul 2014 08:24:21 +0100 Jamie Lentin [off-list ref] wrote:
Signed-off-by: Jamie Lentin <redacted>
Reviewed-by: Antonio Ospite <redacted>
quoted hunk ↗ jump to hunk
--- drivers/hid/hid-lenovo.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index d11e337..a1a693c 100644 --- a/drivers/hid/hid-lenovo.c +++ b/drivers/hid/hid-lenovo.c@@ -349,7 +349,7 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev) struct lenovo_drvdata_tpkbd *data_pointer; size_t name_sz = strlen(dev_name(dev)) + 16; char *name_mute, *name_micmute; - int i; + int i, ret;
Preferred style is one declaration per line, but this style is also quite common in kernel, so it's not a big deal.
quoted hunk ↗ jump to hunk
/* * If this is the pointer half of the keyboard, input_mapping should@@ -369,10 +369,9 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev) if (!hid_validate_values(hdev, HID_OUTPUT_REPORT, 3, 0, 2)) return -ENODEV; - if (sysfs_create_group(&hdev->dev.kobj, - &lenovo_attr_group_tpkbd)) { + ret = sysfs_create_group(&hdev->dev.kobj, &lenovo_attr_group_tpkbd); + if (ret) hid_warn(hdev, "Could not create sysfs group\n"); - } data_pointer = devm_kzalloc(&hdev->dev, sizeof(struct lenovo_drvdata_tpkbd),-- 2.0.0
-- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing?