Re: [PATCH] GPIO button wth wakeup attribute is supposed to wake the system up
From: Rafael J. Wysocki <hidden>
Date: 2014-07-08 20:34:49
Also in:
lkml
On Thursday, June 19, 2014 08:51:25 AM Li, Aubrey wrote:
When the wakeup attribute is set, the GPIO button is capable of waking up the system from sleep states, including the "freeze" sleep state. For that to work, its driver needs to pass the IRQF_NO_SUSPEND flag to devm_request_any_context_irq(), or the interrupt will be disabled by suspend_device_irqs() and the system won't be woken up by it from the "freeze" sleep state. The suspend_device_irqs() routine is a workaround for drivers that mishandle interrupts triggered when the devices handled by them are suspended, so it is safe to use IRQF_NO_SUSPEND in all drivers that don't have that problem. The affected/tested machines include Dell Venue 11 Pro and Asus T100TA. Signed-off-by: Aubrey Li <redacted> Reviewed-by: Rafael J. Wysocki <redacted>
OK Due to the lack of response (ie. no objections) and because the issue addressed by this patch is real, I'm queuing it up as a PM-related fix for 3.17. Rafael
quoted hunk ↗ jump to hunk
--- drivers/input/keyboard/gpio_keys.c | 8 ++++++++ 1 file changed, 8 insertions(+)diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index 8c98e97..b046dc6 100644 --- a/drivers/input/keyboard/gpio_keys.c +++ b/drivers/input/keyboard/gpio_keys.c@@ -527,6 +527,14 @@ static int gpio_keys_setup_key(struct platform_device *pdev, if (!button->can_disable) irqflags |= IRQF_SHARED; + /* + * If platform has specified the wakeup attribute of the button, + * we add IRQF_NO_SUSPEND to desc->action->flag. So the wake up + * interrupt will not be disabled in suspend_device_irqs + */ + if (button->wakeup) + irqflags |= IRQF_NO_SUSPEND; + error = devm_request_any_context_irq(&pdev->dev, bdata->irq, isr, irqflags, desc, bdata); if (error < 0) {
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.