Re: [PATCH v2 1/1] elantech: Add support for trackpoint found on some v3 models
From: Greg KH <hidden>
Date: 2014-06-12 18:44:54
On Thu, Jun 12, 2014 at 08:15:01PM +0200, Ulrik De Bie wrote:
Some elantech v3 touchpad equipped laptops also have a trackpoint, before this commit, these give sync errors. With this patch, the trackpoint is provided as another input device: 'Elantech PS/2 TrackPoint' The patch will also output messages that do not follow the expected pattern. In the mean time I've seen 2 unknown packets occasionally: 0x04 , 0x00 , 0x00 , 0x00 , 0x00 , 0x00 0x00 , 0x00 , 0x00 , 0x02 , 0x00 , 0x00 I don't know what those are for, but they can be safely ignored. Currently all packets that are not known to v3 touchpad and where packet[3] (the fourth byte) lowest nibble is 6 are now recognized as PACKET_TRACKPOINT and processed by the new elantech_report_trackpoint. This has been verified to work on a laptop Lenovo L530 where the touchpad/trackpoint combined identify themselves as: psmouse serio1: elantech: assuming hardware version 3 (with firmware version 0x350f02) psmouse serio1: elantech: Synaptics capabilities query result 0xb9, 0x15, 0x0c. Reviewed-by: Hans de Goede <redacted> Cc: stable@vger.kernel.org Signed-off-by: Ulrik De Bie <redacted> --- drivers/input/mouse/elantech.c | 104 +++++++++++++++++++++++++++++++++++++++-- drivers/input/mouse/elantech.h | 4 ++ 2 files changed, 105 insertions(+), 3 deletions(-)
This seems like a new feature to me and not a stable kernel patch. How does this fit in with the Documentation/stable_kernel_rules.txt requirements? thanks, greg k-h