Re: [patch] Input: edt-ft5x06 - fix an i2c write for M09 support
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2014-06-08 05:36:44
Also in:
kernel-janitors
On Sun, Jun 08, 2014 at 01:53:48AM +0200, Simon Budig wrote:
Hi all. I received notice from Robert Wörle who spotted a bug in the ft5x06 driver (M09 support) which can result in bogus values being written into the configuration registers. Paul wrote:quoted
I think i found the problem, as the driver sends 3 bytes instead of 2 when accessing a register on the M09 firmware. Therefore , writing to gain seems to overflow into the offset register. This seems to be even in the lastet upstream driver so i created a patch for this driver which you find attached. @Simon Budig Find attached a patch to fix this edt driver bug, feel free to comment , test and commit upstream ;-)He is right, his fix is correct. Please include his patch into the repository. Acked-By: Simon Budig <redacted>
Applied, thank you.
Thanks,
Simon
--
Simon Budig kernel concepts GmbH
simon.budig@kernelconcepts.de Sieghuetter Hauptweg 48
+49-271-771091-17 D-57072 Siegenquoted hunk ↗ jump to hunk
From 36b9ac0e8206efefc8795c925b0f3b63ab29fd08 Mon Sep 17 00:00:00 2001 From: Robert Woerle <redacted> Date: Wed, 28 May 2014 13:22:09 +0200 Subject: [PATCH] Input: edt-ft5x06 - fix i2c writes to 2 bytes on M09 firmware Signed-off-by: Robert Woerle <redacted> --- drivers/input/touchscreen/edt-ft5x06.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c index f8815be..d4f3399 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c@@ -271,7 +271,7 @@ static int edt_ft5x06_register_write(struct edt_ft5x06_ts_data *tsdata, wrbuf[0] = addr; wrbuf[1] = value; - return edt_ft5x06_ts_readwrite(tsdata->client, 3, + return edt_ft5x06_ts_readwrite(tsdata->client, 2, wrbuf, 0, NULL); default:-- 1.7.9.5
-- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html