Re: [PATCH 2/2 v3] HID: leds: move led_mode attribute to led-class devices in MSI GT683R driver
From: Johan Hovold <johan@kernel.org>
Date: 2014-06-30 10:40:37
Also in:
linux-leds, lkml
On Wed, Jun 25, 2014 at 09:13:09PM +0300, Janne Kanniainen wrote:
quoted hunk ↗ jump to hunk
Move led_mode attribute from HID device to led-class devices and rename it msi_mode. This will also fix race condition by using attribute-groups. Signed-off-by: Janne Kanniainen <redacted> --- Changes in v3: - Style fixes - Rename sysfs-class-hid-driver-gt683r to sysfs-class-leds-driver-gt683r .../ABI/testing/sysfs-class-hid-driver-gt683r | 14 ----------- .../ABI/testing/sysfs-class-leds-driver-gt683r | 16 +++++++++++++ drivers/hid/hid-gt683r.c | 28 ++++++++++++---------- 3 files changed, 32 insertions(+), 26 deletions(-) delete mode 100644 Documentation/ABI/testing/sysfs-class-hid-driver-gt683r create mode 100644 Documentation/ABI/testing/sysfs-class-leds-driver-gt683rdiff --git a/Documentation/ABI/testing/sysfs-class-hid-driver-gt683r b/Documentation/ABI/testing/sysfs-class-hid-driver-gt683r deleted file mode 100644 index 317e9d5..0000000 --- a/Documentation/ABI/testing/sysfs-class-hid-driver-gt683r +++ /dev/null@@ -1,14 +0,0 @@ -What: /sys/class/hidraw/<hidraw>/device/leds_mode -Date: Jun 2014 -KernelVersion: 3.17 -Contact: Janne Kanniainen <janne.kanniainen@gmail.com> -Description: - Set the mode of LEDs - - 0 - normal - 1 - audio - 2 - breathing - - Normal: LEDs are fully on when enabled - Audio: LEDs brightness depends on sound level - Breathing: LEDs brightness varies at human breathing rate\ No newline at end of filediff --git a/Documentation/ABI/testing/sysfs-class-leds-driver-gt683r b/Documentation/ABI/testing/sysfs-class-leds-driver-gt683r new file mode 100644 index 0000000..29769fb --- /dev/null +++ b/Documentation/ABI/testing/sysfs-class-leds-driver-gt683r@@ -0,0 +1,16 @@ +What: /sys/class/leds/<led>/msi_mode
The ABI-file name now sort of matches the attribute path and there are examples of attributes being documented in this particular way, but naming is far from consistent in Documentation/ABI. Perhaps we should use the name field of the attribute group and kill two birds with one stone by making the sysfs file name match the attribute path, while also making it even more obvious that the mode attribute is a driver specific attribute (and not a common led class one) by placing it in a subdirectory. That is, if you set the .name field to "gt683r" (and rename the attribute and ABI-file again) then the file name and attribute path could match: Documentation/ABI/testing/sysfs-class-leds-gt683r What: /sys/class/leds/<led>/gt683r/mode Both patches look good otherwise. Johan