Re: [PATCH] Input: evdev - Fix incorrect kfree of err_free_client after vzalloc
From: David Rientjes <rientjes@google.com>
Date: 2014-06-12 06:49:08
Also in:
lkml
From: David Rientjes <rientjes@google.com>
Date: 2014-06-12 06:49:08
Also in:
lkml
On Thu, 12 Jun 2014, Yongtaek Lee wrote:
This bug was introduced by commit 92eb77d ("Input: evdev - fall back
to vmalloc for client event buffer").
vzalloc is used to alloc memory as fallback in case of failure
of kzalloc. But err_free_client was not considered on below case.
1. kzalloc fail
2. vzalloc success
3. evdev_open_device fail
4. kfree
So that address checking is needed to call correct free function.
Signed-off-by: Yongtaek Lee <redacted>
Reviewed-by: Daniel Stone <redacted>Acked-by: David Rientjes <rientjes@google.com>