Thread (13 messages) 13 messages, 3 authors, 2014-06-09

Re: [PATCHv2 3/3] IIO: hid-sensor-magn-3d: Add in support for True/Magnetic North HID usages

From: Reyad Attiyat <hidden>
Date: 2014-06-04 15:23:57
Also in: linux-iio, lkml

Hey Srinivas,

On Tue, Jun 3, 2014 at 12:43 PM, Srinivas Pandruvada
[off-list ref] wrote:
May be we should have a field in const struct iio_chan_spec, so that we
can dynamically enable disable channels. In this way we can statically
define channels, but can be enabled/disabled dynamically.
Would this require changing iio subsystem to create sysfs entries only
when enabled? Would we need to add functions to disable and enable
later on?
I think we need to present angle in radians. Are you basing change present
in linux-next? This will automatically do in this function.
I'll look into this. What function should I use to make the iio chanel
to report radians?

I don't see kfree. Try devm_kcalloc?
I changed kmemdup to kcalloc so there is still a kfree in the exsiting
code. I can change this to devm_kcalloc but only if we don't go with
static channels that are enabled as found.

Thanks,
Reyad Attiyat
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help