Re: [PATCH] input: rotary encoder: implement quarter period mode
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2014-05-07 18:59:33
Also in:
linux-devicetree
On Wed, May 07, 2014 at 03:45:43PM +0100, Mark Rutland wrote:
Hi, On Wed, Dec 18, 2013 at 02:43:18PM +0000, Sascha Hauer wrote:quoted
Some rotary encoders have a stable state in all output state combinations. Add support for this type of encoder. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Daniel Mack <daniel@zonque.org> Cc: linux-input@vger.kernel.org Cc: devicetree@vger.kernel.org --- .../devicetree/bindings/input/rotary-encoder.txt | 1 + Documentation/input/rotary-encoder.txt | 9 +++++-- drivers/input/misc/rotary_encoder.c | 30 ++++++++++++++++++++-- include/linux/rotary_encoder.h | 1 + 4 files changed, 37 insertions(+), 4 deletions(-)diff --git a/Documentation/devicetree/bindings/input/rotary-encoder.txt b/Documentation/devicetree/bindings/input/rotary-encoder.txt index 3315495..cbdb29b 100644 --- a/Documentation/devicetree/bindings/input/rotary-encoder.txt +++ b/Documentation/devicetree/bindings/input/rotary-encoder.txt@@ -15,6 +15,7 @@ Optional properties: - rotary-encoder,rollover: Automatic rollove when the rotary value becomes greater than the specified steps or smaller than 0. For absolute axis only. - rotary-encoder,half-period: Makes the driver work on half-period mode. +- rotary-encoder,quarter-period: Makes the driver work on quarter-period mode.The new property looks as sane to me as the half-period property, so for the binding addition:
Actually, maybe we should deprecate rotary-encoder,half-period and instead add rotary-encoder,type property? Thanks. -- Dmitry