On Mon, May 19, 2014 at 3:01 PM, Kees Cook [off-list ref] wrote:

Pinging on this patch... I don't see it in -next yet. I've had more
reports of trouble with logitech devices, and this seems to solve the
problem.

-Kees

On Thu, Apr 17, 2014 at 1:22 PM, Kees Cook [off-list ref] wrote:

quoted

Some drivers use the first HID report in the list instead of using an
index. In these cases, validation uses ID 0, which was supposed to mean
"first known report". This fixes the problem, which was causing at least
the lgff family of devices to stop working since hid_validate_values
was being called with ID 0, but the devices used single numbered IDs
for their reports:

0x05, 0x01,         /*  Usage Page (Desktop),                   */
0x09, 0x05,         /*  Usage (Gamepad),                        */
0xA1, 0x01,         /*  Collection (Application),               */
0xA1, 0x02,         /*      Collection (Logical),               */
0x85, 0x01,         /*          Report ID (1),                  */
...

Reported-by: Simon Wood <redacted>
Signed-off-by: Kees Cook <redacted>
Cc: stable@vger.kernel.org
---

Oops, sorry, I should have commented on it earlier:

Reviewed-by: Benjamin Tissoires <redacted>

Cheers,
Benjamin