Re: Re: [PATCH v2 2/8] mfd: AXP20x: Add bindings documentation

On Sat, Mar 22, 2014 at 03:11:57PM +0100, Carlo Caione wrote:

quoted

quoted

+
+Example:
+
+axp: axp20x@34 {
+	reg = <0x34>;
+	interrupt-parent = <&nmi_intc>;
+	interrupts = <0 8>;
+
+	compatible = "x-powers,axp209";
+	interrupt-controller;
+	#interrupt-cells = <1>;
+
+	regulators {

Do we really need that subnode ? it looks useless, and we already know
that we are defining regulators here.

What do you mean? We are defining the MFD and regulators are just one of
the subsystem here.

I mean that it's useless.

Moveover I'm using the "regulators" node in the
regulators driver (using of_find_node_by_name()) to get the regulators
configuration.

Can't you just use the of_node field of whatever struct device you
get?

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com