On 3/27/2014 4:20 AM, Dmitry Torokhov wrote:

On Wed, Mar 26, 2014 at 05:04:04PM +0000, One Thousand Gnomes wrote:

quoted

On Wed, 26 Mar 2014 13:01:36 +0800
"Zhu, Lejun" [off-list ref] wrote:

quoted

This patch adds support for the GPIO buttons on some Intel Bay Trail
tablets originally running Windows 8. The ACPI description of these
buttons follows "Windows ACPI Design Guide for SoC Platforms".

I'm not sure calling it "Baytrail" is right here - it's in theory a
generic interface so probably should be named accordingly

Otherwise looks good to me.

It uses static devices in non-board code - if I unbind and rebind PNP
device that produces gpio-keys platform devices driver core will not be
happy.

Thanks.

Alan, I will think of a better name for it. This is supposed to work for
other "win8 ready" tablets as well, just all I have today are Baytrail
tablets.

Dmitry, thank you for pointing out the bug. I'll fix it and submit again.

Thanks.
Lejun