On March 16, 2014 7:16:39 PM GMT+00:00, Alexandre Belloni [off-list ref] wrote:

On 16/03/2014 at 18:16:54 +0000, Jonathan Cameron wrote :

quoted

On 05/03/14 17:35, Alexandre Belloni wrote:

quoted

Old ADCs, as present on the sam9rl and the sam9g45 don't have a TSMR

register

quoted

quoted

and the touchscreen support should be handled differently.

Signed-off-by: Alexandre Belloni

[off-list ref]

quoted

One comment inline about handling of devices where the platform data

doesn't

quoted

include the touchscreen type.  I'd expect zero to be the current

default

quoted

rather than NONE...

quoted

diff --git a/include/linux/platform_data/at91_adc.h

b/include/linux/platform_data/at91_adc.h

quoted

quoted

index fcf73879dbfe..7819fc787731 100644

--- a/include/linux/platform_data/at91_adc.h
+++ b/include/linux/platform_data/at91_adc.h

@@ -7,6 +7,12 @@
 #ifndef _AT91_ADC_H_
 #define _AT91_ADC_H_

+enum atmel_adc_ts_type {

This means that the default for existing touch screens (where the

platform

quoted

data won't include setting this value) will be none.  Is that

correct?

quoted

quoted

+	ATMEL_ADC_TOUCHSCREEN_NONE = 0,
+	ATMEL_ADC_TOUCHSCREEN_4WIRE = 4,
+	ATMEL_ADC_TOUCHSCREEN_5WIRE = 5,
+};
+

This is actually just a snippet that I moved from at91_adc.c to
at91_adc.h. I followed the current behavior.  Until now, using the
touchscreen was only supported through device tree and touchscreen
handling was not activated unless the atmel,adc-ts-wires property is
present.  I guess this is the sane way to go because when you use the
touchscreen, you lose the triggers.

Ah. Thanks for clearing that up. I missed that it previously existed entirely..

-- 
Sent from my Android phone with K-9 Mail. Please excuse my brevity.