Hi Robert,

On 03/13/2014 06:38 PM, Robert Baldyga wrote:

Hi,

This patchset modifies max8997 driver and associated function drivers to use
register maps instead of operating directly on i2c bus. This change allowed
to simplify irq handling, and to move some initializations to individual
function drivers. Hence now when some functions are not enabled, their i2c
clients, regmaps and irqs are not registered.

Best regards
Robert Baldyga
Samsung R&D Institute Poland

Changelog:

v3:
- fix error handling
- fix deinitializations order
- move muic irq enum values renaming to separate patch

v2: https://lkml.org/lkml/2014/3/12/237
- rebase patches on Lee Jones' MFD tree
- add missing selects in Kconfig
- add missing deinitializations
- add interrupt disabling when suspend
- few minor changes and typo fixes

v1: https://lkml.org/lkml/2014/3/11/291

Robert Baldyga (4):
  mfd: max8997: use regmap to access registers
  mfd: max8997: handle IRQs using regmap
  mfd: max8997: change irq names to upper case
  mfd: max8997: move regmap handling to function drivers

 drivers/extcon/extcon-max8997.c     |  181 +++++++++++++---
 drivers/input/misc/max8997_haptic.c |  121 +++++++++--
 drivers/leds/leds-max8997.c         |   13 +-
 drivers/mfd/Kconfig                 |    3 +-
 drivers/mfd/Makefile                |    2 +-
 drivers/mfd/max8997-irq.c           |  387 -----------------------------------
 drivers/mfd/max8997.c               |  236 +++++++--------------
 drivers/power/max8997_charger.c     |   33 +--
 drivers/regulator/max8997.c         |   87 ++++----
 drivers/rtc/rtc-max8997.c           |  102 ++++++---
 include/linux/mfd/max8997-private.h |   88 ++++++--
 11 files changed, 532 insertions(+), 721 deletions(-)
 delete mode 100644 drivers/mfd/max8997-irq.c

This patch fix many parts of previous max8997.
When I testd kernel build, it is ok. 

But, I have a question.
The max8997 is used on trats board based on exynos4210.
Did you test this patchset?

Best Regards,
Chanwoo Choi