Re: [PATCH] HID: sony: Fix work queue issues.

On Wed, Feb 19, 2014 at 1:41 PM, David Herrmann [off-list ref] wrote:

Hi Frank

On Wed, Feb 19, 2014 at 7:09 PM, Frank Praznik [off-list ref] wrote:

quoted

Don't initialize force-feedback for devices that don't support it to avoid calls
to schedule_work() with an uninitialized work_struct.

Move the cancel_work_sync() call out of sony_destroy_ff() since the state worker
is used for the LEDs even when force-feedback is disabled.

Remove sony_destroy_ff() to avoid a compiler warning since it is no longer used.

Signed-off-by: Frank Praznik <redacted>

Sorry, my comment might have been misleading. You have to add the "Cc:
[off-list ref]" line underneath/above your "Signed-off-by".
This will send a notice to the stable guys once the patch is applied
in Linus' tree.

But that's also described in the file Greg posted.

Cheers
David

Actually, does this even need to go into stable? The issue doesn't
exist below kernel 3.14 since the LED system wasn't added until commit
0a286ef278529f2bc4f4bb27c4cf99c05999c818 in December.  Could this just
go into for-3.14/upstream-fixes and for-linus with the other pending
fixes?