[PATCH 1/2] HID: cp2112: make sysfs attributes static
flat view
STALE4627d
From: Jiri Kosina <hidden>
Date: 2014-02-17 22:47:38
Subsystem:
hid core layer, the rest · Maintainers:
Jiri Kosina, Benjamin Tissoires, Linus Torvalds
No need to pollute namespace with dev_attr_*. Signed-off-by: Jiri Kosina <redacted> --- drivers/hid/hid-cp2112.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c
index ca0f356..57cf045 100644
--- a/drivers/hid/hid-cp2112.c
+++ b/drivers/hid/hid-cp2112.c@@ -663,7 +663,7 @@ static ssize_t name##_show(struct device *kdev, \ return ret; \ return scnprintf(buf, PAGE_SIZE, format, ##__VA_ARGS__); \ } \ -DEVICE_ATTR_RW(name); +static DEVICE_ATTR_RW(name); CP2112_CONFIG_ATTR(vendor_id, ({ u16 vid;
@@ -784,7 +784,7 @@ static ssize_t pstr_show(struct device *kdev, } #define CP2112_PSTR_ATTR(name, _report) \ -struct cp2112_pstring_attribute dev_attr_##name = { \ +static struct cp2112_pstring_attribute dev_attr_##name = { \ .attr = __ATTR(name, (S_IWUSR | S_IRUGO), pstr_show, pstr_store), \ .report = _report, \ };
--
Jiri Kosina
SUSE Labs