Thread (42 messages) 42 messages, 8 authors, 2014-02-24

Re: [PATCHv6] staging/iio/adc: change the MXS touchscreen driver implementation

From: Dan Carpenter <hidden>
Date: 2014-02-24 14:47:17
Also in: linux-arm-kernel, linux-iio

On Mon, Feb 24, 2014 at 03:38:26PM +0100, Juergen Beisert wrote:
Hi Dan,

On Monday 24 February 2014 14:33:16 Dan Carpenter wrote:
quoted
On Mon, Feb 24, 2014 at 02:16:24PM +0100, Juergen Beisert wrote:
quoted
quoted
While I don't have much experience with the TS part of the code but I
can investigate if you don't have any idea.
can you please test the following patch?
After releasing the touchscreen the internal state machine was left in a
wrong state.
diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
index e2dd783..558a76c 100644
--- a/drivers/staging/iio/adc/mxs-lradc.c  
+++ b/drivers/staging/iio/adc/mxs-lradc.c
@@ -698,6 +698,7 @@ static void mxs_lradc_finish_touch_event(struct
mxs_lradc *lradc, bool valid) }

        /* if it is released, wait for the next touch via IRQ */
+       lradc->cur_plate = LRADC_TOUCH;
        mxs_lradc_reg_clear(lradc, LRADC_CTRL1_TOUCH_DETECT_IRQ, LRADC_CTRL1);
        mxs_lradc_reg_set(lradc, LRADC_CTRL1_TOUCH_DETECT_IRQ_EN, LRADC_CTRL1);
        } 
I am confused.  Why don't you send this like a normal patch?
For testing fist. But you are right, patch will follow.
Never mind, I suck at reading.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help