Re: [PATCH 2/4] HID: sony: Use standard output reports instead of raw reports to send data to the Dualshock 4.

Hi

On Fri, Jan 17, 2014 at 6:10 PM,  [off-list ref] wrote:

quoted

quoted

Use regular HID output reports instead of raw reports in the
dualshock4_state_worker function.  (Thanks Simon Mungewell)

This description is actually wrong. hid_output_raw_report() is used
for regular HID output reports. What you do, is using SET_REPORT to
synchronously set output-reports. Anyhow, see below for comments.

Hi David,
Can you please confirm whether it is preferred to control the DS4 via
'hid_hw_request()' rather than 'hid_output_raw_report()'? They both appear
to work OK...

It's fine. I just wanted to point out that your description is
inverted. According to the specs a device must support both, but that
is not always true. Most devices seem to require SET_REPORT like you
do, but the wiimote for instance requires async output reports (that
is, *not* via synchronous SET_REPORT).

For the BT connected device we will have to use a different packet to a
different report.

Given that most vendors just implement crappy HID, there's no way to
know which function is right. So as long as it works, it's usually The
Right Way.

But this patch is already merged, so no reason to worry.

Cheers
David