Re: Changes on xpad.c

Hi Thomaz, Nol, Ilia,

Happy New Year!

On Thu, Dec 26, 2013 at 10:07:58PM -0200, Thomaz de Oliveira dos Reis wrote:

Hi!

Hope it is correct.

You forgot to add "Signed-off-by: ..." to your change.

Ilia, Nol, you have added the initial mappings for Razer devices and
chose to map directional pad to buttons instead of HAT0X/Y axis. Could
you remind me why?

Thanks!

2013/12/26 Dmitry Torokhov [off-list ref]

quoted

Hi Tomaz,

On Sat, Dec 21, 2013 at 09:48:12PM -0200, Thomaz de Oliveira dos Reis
wrote:

quoted

Hi!

I noticed that Razer Onza controller, different from tradional xbox
gamepad, the dpad doesn't works in most games. (Some games is possibile

to

quoted

configure changing a config file or with interface options but many games
it doesn't works at all)

Looking at module source code, I saw that  it uses the

MAP_DPAD_TO_BUTTONS

quoted

that was created to use with dance pad (with this controller is not), as
written on this comment:

Line 69:  *  - dance pads will map D-PAD to buttons, not axes

Change this to 0 improve overal compatibility of the controller in most
games, without losing any meaningful functionality.

Also, if someone REALLY need this strange configuration, the user can set
the "dpad_to_buttons" module param as described here:

Line 103: MODULE_PARM_DESC(dpad_to_buttons, "Map D-PAD to buttons rather
than axes for unknown pads");

Attached the modified xpad.c module, downloaded from linux-next git file
from today.

Please generate a unified diff for your change. See
Documentation/SubmittngPatches for explanation how to do this.

Thanks.


--
Dmitry

-- 
Dmitry