Hi,

On 12/10/2013 07:12 AM, Dmitry Torokhov wrote:

<snip>

quoted

quoted

quoted

Small question here: if the touchpad is a clickpad, should'nt we also
remove the BTN_RIGHT bit too?

We could, but I don't see much value in that, and it would also require
if statements in the sync methods to ensure that we don't tree to send
a button event for a button we don't advertise.

We don't need this test in the sync method. The test is already
implemented in input_event. So now, it's just a matter of taste
regarding upper layers. Peter, any thoughts on this?

We should not advertise events that device does not generate. This
should help userspace to decide if emulation is needed or not. Input
core will drop events that are not set up as valid for device, so if we
clear BTN_RIGHT there it should all work.

Ok, v2 adding the clearing of the BTN_RIGHT bit is on its way.

Regards,

Hans