On Mon, Dec 09, 2013 at 03:14:26PM -0500, Benjamin Tissoires wrote:

Hi Chris,

On 05/12/13 19:29, Christopher Heiny wrote:

quoted

This patch implements changes to the synaptics-rmi4 branch of
Dmitry's input tree.  The base for the patch is commit
8ca01dc61a42b6f7bcba052a8c084000f7057a34.

This patch primarily reorders the various declarations in rmi_bus.c in order to
group related elements together, along with some typo fixes.  The code is still
horribly broken, but this change should make the following fixes easier to
 review.

Signed-off-by: Christopher Heiny <redacted>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jean Delvare <redacted>
Cc: Linus Walleij <redacted>
Cc: Joerie de Gram <redacted>
Cc: Benjamin Tissoires <redacted>

---

FWIW, I made a review of the patch.
The patches does not only reorder the functions, but also fix some few
things I will detail later (plus fixes of whitespace/comments issues).
It also changes the exported functions as GPL.

Dmitry, given the current state of the driver (which does not work at
all if I understood correctly), maybe you can pick this one in its
current state.

Applied, thank you.

-- 
Dmitry