Thread (2 messages) 2 messages, 2 authors, 2013-12-02

Re: [PATCH] HID: kye: Fix missing break in kye_report_fixup()

From: Benjamin Tissoires <hidden>
Date: 2013-12-02 14:35:04

On 30/11/13 14:12, Ben Hutchings wrote:
quoted hunk ↗ jump to hunk
The change to support Genius Manticore Keyboard also changed behaviour
for Genius Gx Imperator Keyboard, as there is no break between the
cases.  This is presumably a mistake.

Reported by Coverity as CID 1134029.

Fixes: 4a2c94c9b6c0 ('HID: kye: Add report fixup for Genius Manticore Keyboard')
Signed-off-by: Ben Hutchings <redacted>
---
 drivers/hid/hid-kye.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/hid/hid-kye.c b/drivers/hid/hid-kye.c
index ecb5ca6..e776963 100644
--- a/drivers/hid/hid-kye.c
+++ b/drivers/hid/hid-kye.c
@@ -341,6 +341,7 @@ static __u8 *kye_report_fixup(struct hid_device *hdev, __u8 *rdesc,
 	case USB_DEVICE_ID_GENIUS_GX_IMPERATOR:
 		rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 83,
 					"Genius Gx Imperator Keyboard");
+		break;
 	case USB_DEVICE_ID_GENIUS_MANTICORE:
 		rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 104,
 					"Genius Manticore Keyboard");
Jiri already applied this one, but FWIW:
Reviewed-by: Benjamin Tissoires <redacted>

Thanks for spotting this,
Benjamin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help