Re: [PATCHv2] HID: sony: Send FF commands in non-atomic context
From: <hidden>
Date: 2013-11-17 21:49:27
On Sunday 17 November 2013 14:46:32 simon@mungewell.org wrote:quoted
quoted
drivers/hid/hid-sony.c | 53 +++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 42 insertions(+), 11 deletions(-)Doesn't this miss patching Kconfig (previous changes were reverted). SimonThis was meant as a "replacement"/v2 of the revert patch as said earlier (directly bellow the commit message):quoted
quoted
This patch can replace 'Revert "HID: sony: Add force feedback support for Dualshock3 USB"'And if the maintainer doesn't like the work_queue workaround then he can still apply the revert patch or discuss/propose a different approach.
Patching the original Nov9 patch ([PATCH] HID: sony: Add force feedback support for Dualshock3 USB) and then the 2nd revert ([PATCHv2] HID: sony: Send FF commands in non-atomic context) works for me. Both Sony DualShock2/SixAxis and my wired Itec controller work as expected with 'testrumble' and 'testhaptic'. Thanks for getting this fixed. Simon Signed-off-by: Simon Wood <redacted>