Thread (3 messages) 3 messages, 3 authors, 2013-11-25

Re: [PATCH] HID: i2c-hid: disable interrupt on suspend

From: Jiri Kosina <hidden>
Date: 2013-11-25 22:19:02
Also in: lkml

On Mon, 25 Nov 2013, Benjamin Tissoires wrote:
quoted
When an I2C HID device is powered of during system sleep, as a result of
removing its power resources (by the ACPI core) the interrupt line might go
low as well. This results inadvertent interrupt and wakes the system from
sleep immediately.

To prevent this we disable the device interrupt in the drivers suspend
method and enable it on resume. The device can still wake the system up if
it is wake capable (this also means that not all of its power will be
removed to keep the interrupt line high).

Reported-by: Jerome Blin <redacted>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
Jiri, just FYI, I still do not have any final consumer ready i2c-hid
hardware. So I can not test/debug anything related to the suspend-resume.

If Mika tested it properly (which I expect), you may consider pulling
this one.
Understood, thanks guys.

Applied now.

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help