Thread (16 messages) 16 messages, 4 authors, 2014-01-05

Re: [PATCHv3 1/2] Input: twl4030-keypad - add device tree support

From: Sebastian Reichel <hidden>
Date: 2013-11-24 17:17:34
Also in: linux-devicetree, lkml

Hi,
quoted
quoted
I'd suggest just simple "autorepeat", so that we get rid of ugly double-negation.
The idea was that majority of setups want autorepeat so in the absence
of the property autorepeat is turned on.
I see... but autorepeat on by default makes sense on devices that are
usually querty keybaords, but does not make sense on devices that are
usually phone keypads or power buttons.

So my proposal is:

1) driver decides if it makes sense to autorepeat by default or not.

2) dts says autorepeat=0 or autorepeat=1

That way, we get dts that get chance to work on other OSes, get rid of
double negations, and get right defaults when autorepeat is not
specified.
Sounds fine to me. Any objections?

-- Sebastian

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help