Thread (12 messages) 12 messages, 5 authors, 2013-11-22

Re: [appleir] BUG: unable to handle kernel NULL pointer dereference

From: James Henstridge <hidden>
Date: 2013-11-21 03:20:27
Also in: lkml

On Tue, Nov 19, 2013 at 10:33 PM, Jiri Kosina [off-list ref] wrote:
On Thu, 7 Nov 2013, Benjamin Tissoires wrote:
quoted
quoted
quoted
[ adding some more CCs ]

Okay, so apparently we didn't register with input, but only hiddev /
hidraw.

appleir 0003:05AC:8240.0005: hiddev0,hidraw4: USB HID v1.11 Device [Apple Computer, Inc. IR Receiver] on usb-0000:00:1d.3-2/input0

Therefore ->input_configured() callback has never been called, and thus we
oops due to appleir->input_dev being NULL when the first raw event is
reported.

Could you please provide report descriptor of the device?

The driver apparently relies on it being registered with hid-input, but
for some reason that doesn't happen.
Here is the relevant lsusb output that I think contains what you're
asking for (I had to unbind usbhid for it to include the descriptor):

Bus 005 Device 003: ID 05ac:8240 Apple, Inc. Built-in IR Receiver
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               2.00
...
Ok, thanks for the report. Could you please test the following patch
which should solve your problem (hopefully)?
James,

any reults from testing Benjamin's patch, please?
Sorry for the delays in testing out the patch.  I have tried a kernel
with the patch applied, and can no longer reproduce the oops.  The
hid-appleir driver appears to be working correctly, generating key
press events in response to the remote, and LIRC functions correctly
via hiddev.

Thanks for the everyone's help with this.

James.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help