Re: [PATCH] HID: wiimote: add pro-controller analog stick calibration
From: Jiri Kosina <hidden>
Date: 2013-10-30 13:16:02
On Wed, 30 Oct 2013, Rafael Brune wrote:
quoted
The analog sticks of the pro-controller might report slightly off values. To guarantee a uniform setup, we now calibrate analog-stick values during pro-controller setup. Unfortunately, the pro-controller fails during normal EEPROM reads and I couldn't figure out whether there are any calibration values stored on the device. Therefore, we now use the first values reported by the device (iff they are not _way_ off, which would indicate movement) to initialize the calibration values. To allow users to change this calibration data, we provide a pro_calib sysfs attribute. We also change the "flat" values so user-space correctly smoothes our data. It makes slightly off zero-positions less visible while still guaranteeing highly precise movement reports. Note that the pro controller reports zero-positions in a quite huge range (at least: -100 to +100). Reported-by: Rafael Brune <redacted> Signed-off-by: David Herrmann <redacted>Tested-by: Rafael Brune <redacted>
Applied, thanks. -- Jiri Kosina SUSE Labs