Re: [PATCHv2 1/3] Input: twl4030-pwrbutton - add device tree support
From: Mark Rutland <mark.rutland@arm.com>
Date: 2013-10-23 16:10:37
Also in:
linux-devicetree, lkml
On Wed, Oct 23, 2013 at 04:01:20PM +0100, Sebastian Reichel wrote:
Add device tree support for twl4030 power button driver.
This requires a binding document. As it is it's not possible to review. Mark.
quoted hunk ↗ jump to hunk
Signed-off-by: Sebastian Reichel <redacted> --- drivers/input/misc/twl4030-pwrbutton.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c index b9a05fd..a3a0fe3 100644 --- a/drivers/input/misc/twl4030-pwrbutton.c +++ b/drivers/input/misc/twl4030-pwrbutton.c@@ -52,7 +52,7 @@ static irqreturn_t powerbutton_irq(int irq, void *_pwr) return IRQ_HANDLED; } -static int __init twl4030_pwrbutton_probe(struct platform_device *pdev) +static int twl4030_pwrbutton_probe(struct platform_device *pdev) { struct input_dev *pwr; int irq = platform_get_irq(pdev, 0);@@ -106,16 +106,24 @@ static int __exit twl4030_pwrbutton_remove(struct platform_device *pdev) return 0; } +#if IS_ENABLED(CONFIG_OF) +static const struct of_device_id twl4030_pwrbutton_dt_match_table[] = { + { .compatible = "ti,twl4030-pwrbutton" },
There's no need to shorten this, "ti,twl4030-power-button" would be far easier to understand. Unless the datasheet refers to it as pwrbutton? Thanks, Mark.