Re: [PATCH v2 1/2] Input: rotary-encoder: Add 'stepped' irq handler
From: Ezequiel García <ezequiel@vanguardiasur.com.ar>
Date: 2013-10-12 16:59:02
Also in:
lkml
From: Ezequiel García <ezequiel@vanguardiasur.com.ar>
Date: 2013-10-12 16:59:02
Also in:
lkml
Dmitry, On 4 October 2013 10:18, Daniel Mack [off-list ref] wrote:
On 04.10.2013 14:53, Ezequiel Garcia wrote:quoted
Some rotary-encoder devices (such as those with detents) are capable of producing a stable event on each step. This commit adds support for this case, by implementing a new interruption handler. The handler needs only detect the direction of the turn and generate an event according to this detection.I think you can squash patch 2/2 into this one. It doesn't make much sense to have a one-liner patch to just update the documenation separately. Other than that, the code looks fine to me. Acked-by: Daniel Mack [off-list ref]
Could you merge these two patches? It's already acked by Daniel, and there wasn't any other feedback so I think we're ready to get them in and support more devices :-) -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html