Thread (1 message) 1 message, 1 author, 2013-10-03
STALE4668d

[PATCH 2/9] input: ambakmi: Remove unnecessary amba_set_drvdata()

From: Michal Simek <hidden>
Date: 2013-10-03 09:46:58
Also in: lkml
Subsystem: arm primecell kmi pl050 driver, input (keyboard, mouse, joystick, touchscreen) drivers, the rest · Maintainers: Russell King, Dmitry Torokhov, Linus Torvalds

Driver core clears the driver data to NULL after device_release
or on probe failure, so just remove it from here.

Driver core change:
"device-core: Ensure drvdata = NULL when no driver is bound"
(sha1: 0998d0631001288a5974afc0b2a5f568bcdecb4d)

Signed-off-by: Michal Simek <redacted>
---
 drivers/input/serio/ambakmi.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/input/serio/ambakmi.c b/drivers/input/serio/ambakmi.c
index 4e2fd44..b7c206d 100644
--- a/drivers/input/serio/ambakmi.c
+++ b/drivers/input/serio/ambakmi.c
@@ -167,8 +167,6 @@ static int amba_kmi_remove(struct amba_device *dev)
 {
 	struct amba_kmi_port *kmi = amba_get_drvdata(dev);

-	amba_set_drvdata(dev, NULL);
-
 	serio_unregister_port(kmi->io);
 	clk_put(kmi->clk);
 	iounmap(kmi->base);
--
1.8.2.3

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help