Re: [PATCH 5/6] Staging/iio/adc/touchscreen/MXS: add interrupt driven touch detection

Dear Jürgen Beisert,

Hi Marek,

On Monday 16 September 2013 16:23:48 Marek Vasut wrote:

quoted

quoted

On Sunday 15 September 2013 12:56:25 Jonathan Cameron wrote:

quoted

On 09/11/13 09:18, Juergen Beisert wrote:

quoted

For battery driven systems it is a very bad idea to collect the
touchscreen data within a kernel busy loop.

This change uses the features of the hardware to delay and
accumulate samples in hardware to avoid a high interrupt and CPU
load.

Note: this is only tested on an i.MX23 SoC yet.

Signed-off-by: Juergen Beisert <redacted>
CC: linux-arm-kernel@lists.infradead.org
CC: devel@driverdev.osuosl.org
CC: Marek Vasut <marex@denx.de>
CC: Fabio Estevam <redacted>
CC: Jonathan Cameron <redacted>

While this driver is placed in IIO within staging at the moment,
these changes are definitely input related.  Hence I have cc'd
Dmitry and the input list.

I am personaly a little uncomfortable that we have such a complex bit
of input code sat within an IIO driver but such is life.

Maybe an MFD for this ADC unit would be a better way to go? Currently I
have a different problem with this driver, because the ADC unit
monitors the battery as well. And the charging driver from the power
subsystem needs these values to charge the battery in a correct
manner.

Are you planning to post the power block patches too ?

When they will work: yes. Currently it crashes all the time. The PMIC is a
beast...

Full ACK

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html