Re: [PATCH 1/1] Drivers: input: serio: New driver to support Hyper-V synthetic keyboard
From: Dan Carpenter <hidden>
Date: 2013-09-16 20:13:55
Also in:
lkml
From: Dan Carpenter <hidden>
Date: 2013-09-16 20:13:55
Also in:
lkml
On Mon, Sep 16, 2013 at 06:42:25PM +0000, KY Srinivasan wrote:
Dan, Rolling the changes you have indicated is not the issue; this can trivially be done. My contention is that it is not needed given that the underlying function is already doing that. Look at the function vmbus_recvpacket_raw() in drivers/hv/channel.c.
I'm confused. There is no mention of ->offset8 in vmbus_recvpacket_raw(). It's a good idea to add a check there but the lower levels don't know about the sizeof(synth_kbd_protocol_response) so we would still need something like my check. regards, dan carpenter