Re: [PATCH] Input: atmel_mxt_ts - update to devm_* API
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2013-09-16 15:07:04
Also in:
lkml
Hi Manish, On Mon, Sep 16, 2013 at 08:20:16PM +0530, Manish Badarkhe wrote:
quoted hunk ↗ jump to hunk
@@ -1264,10 +1261,8 @@ static int mxt_remove(struct i2c_client *client) struct mxt_data *data = i2c_get_clientdata(client); sysfs_remove_group(&client->dev.kobj, &mxt_attr_group); - free_irq(data->irq, data); input_unregister_device(data->input_dev); kfree(data->object_table); - kfree(data);
YOu need to be _very_ careful when mixing devm_* and non-devm-managed resources, especially when interrupt is involved. In this particular case you are offloading freeing of the interrupt (and disabling it) to devm, which will happen later, bu you are freeing object table immediately. This may cause driver crash if interrupt comes while device is being unbound. That said, there is a large outstanding series to the driver from Nick Dryer that I am trying to merge, you may want to coordinate this change with him. Thanks. -- Dmitry