Thread (2 messages) 2 messages, 2 authors, 2013-09-01

Re: [PATCH 2/3] driver: input: twl4030-vibra: fix missing of_node_put

From: Peter Ujfalusi <hidden>
Date: 2013-09-01 17:01:31
Also in: lkml

On 08/31/2013 09:45 AM, Libo Chen wrote:
decrease node device_node refcount after task completion

Signed-off-by: Libo Chen <redacted>
Acked-by: Peter Ujfalusi <redacted>
quoted hunk ↗ jump to hunk
---
 drivers/input/misc/twl4030-vibra.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/input/misc/twl4030-vibra.c b/drivers/input/misc/twl4030-vibra.c
index 68a5f33..b8d1526 100644
--- a/drivers/input/misc/twl4030-vibra.c
+++ b/drivers/input/misc/twl4030-vibra.c
@@ -185,8 +185,10 @@ static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata,
 	if (pdata && pdata->coexist)
 		return true;

-	if (of_find_node_by_name(node, "codec"))
+	if (of_find_node_by_name(node, "codec")) {
+		of_node_put(node);
 		return true;
+	}

 	return false;
 }

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help