Re: [PATCH 2/2] iio: ti_am335x_adc: Add continuous sampling support
From: Sebastian Andrzej Siewior <hidden>
Date: 2013-08-28 16:43:13
Also in:
linux-iio, lkml
* Zubair Lutfullah | 2013-08-25 23:45:24 [+0100]:
quoted hunk ↗ jump to hunk
diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c index a952538..ae2202b 100644 --- a/drivers/iio/adc/ti_am335x_adc.c +++ b/drivers/iio/adc/ti_am335x_adc.c@@ -231,28 +406,56 @@ static int tiadc_probe(struct platform_device *pdev)
…
+err_free_device: + iio_device_free(indio_dev);
I am not sure about this one.
quoted hunk ↗ jump to hunk
+err_ret: return err; }@@ -262,11 +465,14 @@ static int tiadc_remove(struct platform_device *pdev)struct tiadc_device *adc_dev = iio_priv(indio_dev); u32 step_en; + free_irq(adc_dev->irq, indio_dev); iio_device_unregister(indio_dev); + iio_buffer_unregister(indio_dev); tiadc_channels_remove(indio_dev); step_en = get_adc_step_mask(adc_dev); am335x_tsc_se_clr(adc_dev->mfd_tscadc, step_en); + iio_device_free(indio_dev);
But this one is wrong. The will be removed via dev_res() and if you do it here as well then dev_res() will decrement the reference of an unused object.
return 0; }
Sebastian