Re: [PATCH 1/2] HID: apple: Add another device ID for the mid-2013 Macbook Air
From: Henrik Rydberg <hidden>
Date: 2013-08-25 07:05:57
Also in:
lkml
Subsystem:
apple bcm5974 multitouch driver, input (keyboard, mouse, joystick, touchscreen) drivers, the rest · Maintainers:
Henrik Rydberg, Dmitry Torokhov, Linus Torvalds
Hi Ian,
This patch adds a device ID found for mid-2013 Macbook Air 6,1 from lsusb: Bus 001 Device 003: ID 05ac:0290 Apple, Inc. Since IDs already exist for this generation Macbook air as WELLSPRING8, name this one WELLSPRING8A. This only adds an ANSI version since it's device ID is only one less than the existing WELLSPRING8 IDs.
This seems to indicate that we got the ANSI/ISO numbers wrong in a recent patch. IIRC, there was doubt already when the patch was applied (Linus T CC'd). Most likely the right patch is this:
diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
index 4ef4d5e..a73f961 100644
--- a/drivers/input/mouse/bcm5974.c
+++ b/drivers/input/mouse/bcm5974.c@@ -89,9 +89,9 @@ #define USB_DEVICE_ID_APPLE_WELLSPRING7A_ISO 0x025a #define USB_DEVICE_ID_APPLE_WELLSPRING7A_JIS 0x025b /* MacbookAir6,2 (unibody, June 2013) */ -#define USB_DEVICE_ID_APPLE_WELLSPRING8_ANSI 0x0291 -#define USB_DEVICE_ID_APPLE_WELLSPRING8_ISO 0x0292 -#define USB_DEVICE_ID_APPLE_WELLSPRING8_JIS 0x0293 +#define USB_DEVICE_ID_APPLE_WELLSPRING8_ANSI 0x0290 +#define USB_DEVICE_ID_APPLE_WELLSPRING8_ISO 0x0291 +#define USB_DEVICE_ID_APPLE_WELLSPRING8_JIS 0x0292 #define BCM5974_DEVICE(prod) { \ .match_flags = (USB_DEVICE_ID_MATCH_DEVICE | \
Brad, Linus, does the above patch work for you as well as for Ian? Thanks, Henrik