Thread (9 messages) 9 messages, 4 authors, 2013-09-22

Re: [PATCH 3/3] thinkpad_acpi: Wire unused micmute LED to capslock

From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: 2013-08-22 17:30:21
Also in: linux-acpi, lkml

On Thu, Aug 22, 2013 at 5:39 PM, Matthew Garrett [off-list ref] wrote:
I think there's a risk of user confusion here, in that it's now possible
for the mic mute light to be lit despite the internal microphone still
being active. That seems like surprising behaviour.
Yeah, that is a legitimate concern. Patches 1/3 [1] and 2/3 [2]
clearly make sense, as they're generic and don't really suggest any
new behavior.

But setting this behavior here as the default could indeed be a bit
unexpected. I think it's fair to reject this patch (3/3), but accept
the first two. Tweakers who have the same early boot caps-lock LED
needs as me can simply put this in their initramfs after 1/3 and 2/3
are applied:

# echo caps-lock >
/sys/devices/platform/thinkpad_acpi/leds/tpacpi\:\:micmute/trigger

Jason

[1] https://lkml.org/lkml/2013/8/22/310
[2] https://lkml.org/lkml/2013/8/22/313
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help