Thread (10 messages) 10 messages, 4 authors, 2013-08-22

Re: [PATCH v2 0/3] HID: Win 8 multitouch panels detection in core

From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date: 2013-08-21 21:17:47
Also in: lkml

On 08/21/2013 08:40 AM, Benjamin Tissoires wrote:
Hi guys,

this is the v2 of the rework of the pre-scanning of the hid report descriptors.
This allows us to be able to detect Win 8 multitouch panels.
I tried to take into account all of the previous reviews, and I think the patch
series is in a better shape now.

Alexander, Srinivas, could you please review/test patches 1/3 and 2/3 as they
will both impact hid_sensor_hub detection now. From the report descriptors
Alexander sent, I would say that it will work now, but it's always better to
have different testers :)
Tested sensor hub. It works.
Cheers,
Benjamin

Changes in v2:
- moved "flags" processing in patch 2/3
- do not introduce parser->flags, but use hid->group as a temporary flag placeholder
- hid_scan_report() is less verbose when errors are found in the descriptor
- hid_scan_report() is tolerant to parsing errors
- fixed usage_page handling in hid_scan_collection(), which fixes sensors detection
- amended commit messages
- #define and #undef HID_FLAG_* in hid-core.c instead of hid.h

Benjamin Tissoires (3):
   HID: Use hid_parser for pre-scanning the report descriptors
   HID: detect Win 8 multitouch devices in core
   HID: do not init input reports for Win 8 multitouch devices

  drivers/hid/hid-core.c        | 143 ++++++++++++++++++++++++++++++------------
  drivers/hid/hid-multitouch.c  |  36 +++++++----
  drivers/hid/usbhid/hid-core.c |  11 +++-
  include/linux/hid.h           |   2 +
  4 files changed, 137 insertions(+), 55 deletions(-)
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help