Re: [PATCH 4/4] iio: ti_am335x_adc: Add continuous sampling and trigger support
flat view
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: 2013-08-16 14:59:54
Also in:
linux-iio, lkml
* Zubair Lutfullah | 2013-08-13 21:05:03 [+0100]:
quoted hunk ↗ jump to hunk
diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c index 3ceac3e..0d7e313 100644 --- a/drivers/iio/adc/ti_am335x_adc.c +++ b/drivers/iio/adc/ti_am335x_adc.c
…
quoted hunk ↗ jump to hunk
+static int tiadc_buffer_postdisable(struct iio_dev *indio_dev) +{ + struct tiadc_device *adc_dev = iio_priv(indio_dev); + int config; + + tiadc_step_config(indio_dev); + if (adc_dev->mfd_tscadc->tsc_cell == -1) { + config = tiadc_readl(adc_dev, REG_CTRL); + tiadc_writel(adc_dev, REG_CTRL, (config | CNTRLREG_TSCSSENB)); + }
This kind of check is bad. The tsc cell may have been created but the driver not enabled or loaded. Further you should document why you need to enable / disable the ADC in this places and only if the TSC part is not active. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html