Re: [PATCH v2 1/1] input: ideapad_slidebar: new input driver
flat view
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2013-08-07 18:43:00
Also in:
lkml
Hi Andrey, On Wed, Aug 07, 2013 at 03:25:34PM +0400, Andrey Moiseev wrote:
quoted hunk ↗ jump to hunk
+/* Keyboard handler */ +static irq_handler_t kbd_irq_handler(int irq, void *dev_id, + struct pt_regs *regs) +{ + /* Scancodes: e03b on move, bb on release */ + int scancode = inb(0x60);
No, you should not just read KBC data without regard to what other parts of kernel are doing (i8042 might be accessing it at the same time because AUX IRQ was raised). This driver has to be implemented as i8042 filter. Thanks. -- Dmitry