On 07/03/2013 04:50 PM, Dan Carpenter wrote:

On Wed, Jul 03, 2013 at 04:12:48PM +0300, Ferruh Yigit wrote:

quoted

On 07/03/2013 12:44 AM, Dan Carpenter wrote:

quoted

We leak "cd" if the cd->xfer_buf allocation fails.  It was weird to
"goto error_gpio_irq" so I changed the label name.  (Label names should
reflect the label location not the goto location otherwise you get an
"all roads lead to Rome problem").

Signed-off-by: Dan Carpenter <redacted>

xfer_buf still may not be freed, I propose following one instead:

That's a good point.  I missed that leak.  The problem is that my
patch was already applied so this patch would have to be re-written
on top of that.  Also this patch is whitespace dammaged and won't
apply.

OK, I am preparing the patch over previous one.

Thanks,
ferruh
This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.