Thread (6 messages) 6 messages, 4 authors, 2013-07-07

re: Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices

From: Dan Carpenter <hidden>
Date: 2013-07-02 21:47:30

Hello Ferruh Yigit,

The patch 67bf12ca50d5: "Input: cyttsp4 - SPI driver for Cypress
TMA4XX touchscreen devices" from Jun 30, 2013, leads to the following
Smatch warning:
"drivers/input/touchscreen/cyttsp4_spi.c:66 cyttsp_spi_xfer()
	 warn: impossible condition '(reg > 255) => (0-255 > 255)'"

drivers/input/touchscreen/cyttsp4_spi.c
    66          if (reg > 255)
                    ^^^^^^^^^
"reg" is unsigned char so 255 is the max it can be.
    67                  wr_buf[0] = op + CY_SPI_A8_BIT;
    68          else
    69                  wr_buf[0] = op;

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help