[PATCH 50/50] staging: vt6656: spin_lock in complete() cleanup
flat view
STALE4822d
From: Ming Lei <hidden>
Date: 2013-07-11 09:13:17
Also in:
alsa-devel, linux-media, linux-wireless, netdev
Subsystem:
staging subsystem, the rest · Maintainers:
Greg Kroah-Hartman, Linus Torvalds
Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: devel@driverdev.osuosl.org Signed-off-by: Ming Lei <redacted> --- drivers/staging/vt6656/usbpipe.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
index 098be60..0282f2e 100644
--- a/drivers/staging/vt6656/usbpipe.c
+++ b/drivers/staging/vt6656/usbpipe.c@@ -485,6 +485,7 @@ static void s_nsBulkInUsbIoCompleteRead(struct urb *urb) int bIndicateReceive = false; int bReAllocSkb = false; int status; + unsigned long flags; DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"---->s_nsBulkInUsbIoCompleteRead\n"); status = urb->status;
@@ -515,18 +516,18 @@ static void s_nsBulkInUsbIoCompleteRead(struct urb *urb) STAvUpdateUSBCounter(&pDevice->scStatistic.USB_BulkInStat, status); if (bIndicateReceive) { - spin_lock(&pDevice->lock); + spin_lock_irqsave(&pDevice->lock, flags); if (RXbBulkInProcessData(pDevice, pRCB, bytesRead) == true) bReAllocSkb = true; - spin_unlock(&pDevice->lock); + spin_unlock_irqrestore(&pDevice->lock, flags); } pRCB->Ref--; if (pRCB->Ref == 0) { DBG_PRT(MSG_LEVEL_DEBUG, KERN_INFO"RxvFreeNormal %d \n",pDevice->NumRecvFreeList); - spin_lock(&pDevice->lock); + spin_lock_irqsave(&pDevice->lock, flags); RXvFreeRCB(pRCB, bReAllocSkb); - spin_unlock(&pDevice->lock); + spin_unlock_irqrestore(&pDevice->lock, flags); } return;
--
1.7.9.5