Re: [RESEND][PATCH] cyttsp: Fix swap of mfg_stat and mfg_cmd registers
From: Javier Martinez Canillas <javier@dowhile0.org>
Date: 2013-06-30 00:32:14
Also in:
lkml
On Sat, Jun 29, 2013 at 6:53 PM, Matthias Kaehlcke [off-list ref] wrote:
quoted hunk
The command and status register in the driver were swapped with respect to the order specified in the datasheet (CY8CTMA140). Confirmed with Cypress that the order in the datasheet is correct. Signed-off-by: Matthias Kaehlcke <redacted> Acked-by: Javier Martinez Canillas <javier@dowhile0.org> Acked-by: Ferruh Yigit <redacted> --- drivers/input/touchscreen/cyttsp_core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/input/touchscreen/cyttsp_core.h b/drivers/input/touchscreen/cyttsp_core.h index 1aa3c69..f1ebde3 100644 --- a/drivers/input/touchscreen/cyttsp_core.h +++ b/drivers/input/touchscreen/cyttsp_core.h@@ -67,8 +67,8 @@ struct cyttsp_xydata { /* TTSP System Information interface definition */ struct cyttsp_sysinfo_data { u8 hst_mode; - u8 mfg_cmd; u8 mfg_stat; + u8 mfg_cmd; u8 cid[3]; u8 tt_undef1; u8 uid[8]; --1.7.10.4 --
Hi Matthias, This patch has already been merged in Linus tree a few days ago with commit ID d3bf073aa. Thanks a lot and best regards, Javier