Thread (5 messages) 5 messages, 4 authors, 2013-06-18

Re: [PATCH] input: cros_ec_keyb_clear_keyboard() depends on CONFIG_PM_SLEEP

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2013-06-18 08:39:15
Also in: lkml

On Tue, Jun 18, 2013 at 1:16 AM, Samuel Ortiz [off-list ref] wrote:
On Tue, May 14, 2013 at 11:42:48PM -0700, Dmitry Torokhov wrote:
quoted
On Wed, May 08, 2013 at 09:25:56PM -0600, Simon Glass wrote:
quoted
On Wed, May 8, 2013 at 3:45 PM, Geert Uytterhoeven [off-list ref] wrote:
quoted
If CONFIG_PM_SLEEP is not set:

drivers/input/keyboard/cros_ec_keyb.c:211: warning: ‘cros_ec_keyb_clear_keyboard’ defined but not used

Move the definition of cros_ec_keyb_clear_keyboard() inside the section
protected by #ifdef CONFIG_PM_SLEEP to fix this.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Simon Glass <sjg@chromium.org>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Could you please forward this to Linus as I do not have this driver in
my branch yet.
I guess you took that one now ? Or are you expecting me to merge it ?
FWIW, I also have it in my exotic-arch-fixes branch, now destined for 3.11.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help