Re: [PATCH 1/2] Input: touchscreen: ads7846: copy info from pdata to private struct
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2013-05-06 03:24:46
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2013-05-06 03:24:46
Hi Daniel, On Thu, Apr 25, 2013 at 01:33:52PM +0200, Daniel Mack wrote:
In preparation for DT bindings, we have to store all runtime information inside struct ads7846. Add more variable to struct ads7846 and refactor some code so the probe-time supplied pdata is not used from any other function than the probe() callback.
I think more common pattern is to allocate platform data structure when parsing device tree, often with devm_kzalloc() so it is cleaned up after driver is unbound. Thanks. -- Dmitry