Thread (5 messages) 5 messages, 3 authors, 2013-05-06

Re: [PATCH 1/3] Input: altera_ps2 - Remove redundant platform_set_drvdata()

From: Thomas Chou <hidden>
Date: 2013-05-06 01:48:20

Hi Sachin,

On 05/03/2013 06:36 PM, Sachin Kamat wrote:
quoted hunk ↗ jump to hunk
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.

Signed-off-by: Sachin Kamat <redacted>
Cc: Thomas Chou <redacted>
---
  drivers/input/serio/altera_ps2.c |    1 -
  1 file changed, 1 deletion(-)
diff --git a/drivers/input/serio/altera_ps2.c b/drivers/input/serio/altera_ps2.c
index 479ce5f..a0a2657 100644
--- a/drivers/input/serio/altera_ps2.c
+++ b/drivers/input/serio/altera_ps2.c
@@ -163,7 +163,6 @@ static int altera_ps2_remove(struct platform_device *pdev)
  {
  	struct ps2if *ps2if = platform_get_drvdata(pdev);

-	platform_set_drvdata(pdev, NULL);
  	serio_unregister_port(ps2if->io);
  	free_irq(ps2if->irq, ps2if);
  	iounmap(ps2if->base);
Acked-by: Thomas Chou <redacted>

Thanks.
- Thomas

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help