Thread (12 messages) 12 messages, 4 authors, 2013-05-06

Re: [PATCH 3/9] Input: gpio_tilt_polled - Remove redundant platform_set_drvdata()

From: Heiko Stübner <heiko@sntech.de>
Date: 2013-05-04 19:44:54

Am Samstag, 4. Mai 2013, 16:51:52 schrieb Sachin Kamat:
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.

Signed-off-by: Sachin Kamat <redacted>
Cc: Heiko Stuebner <heiko@sntech.de>
not sure, if it's needed for such a small change, but nevertheless
Acked-by: Heiko Stuebner <heiko@sntech.de>
quoted hunk ↗ jump to hunk
---
 drivers/input/misc/gpio_tilt_polled.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/input/misc/gpio_tilt_polled.c
b/drivers/input/misc/gpio_tilt_polled.c index da05cca..714c683 100644
--- a/drivers/input/misc/gpio_tilt_polled.c
+++ b/drivers/input/misc/gpio_tilt_polled.c
@@ -184,8 +184,6 @@ static int gpio_tilt_polled_remove(struct
platform_device *pdev) struct gpio_tilt_polled_dev *tdev =
platform_get_drvdata(pdev);
 	const struct gpio_tilt_platform_data *pdata = tdev->pdata;

-	platform_set_drvdata(pdev, NULL);
-
 	input_unregister_polled_device(tdev->poll_dev);
 	input_free_polled_device(tdev->poll_dev);
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help