Thread (7 messages) 7 messages, 3 authors, 2013-05-23
STALE4765d

Re: [PATCH] input: sirfsoc_pwrc: add onkey input driver for CSR SiRFprimaII PWRC

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2013-05-23 16:29:16
Also in: linux-arm-kernel

Hi Madhvapathi,

On Thu, May 23, 2013 at 01:49:10PM +0000, Madhvapathi Sriram wrote:
Possible mem leak here not freeing any allocated devices/memory/irq.
I suggest all the error handling be collated at the end of this
function for various stages and error handling be done there.
Please have a look at
https://www.kernel.org/doc/Documentation/input/input-programming.txt
Please note that the driver uses managed resources which get cleaned
automatically.

Also, could you please use a sane mailer that wraps long lines properly.

Thanks.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help