Re: [PATCH] input: sirfsoc_pwrc: add onkey input driver for CSR SiRFprimaII PWRC
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2013-05-23 16:29:16
Also in:
linux-arm-kernel
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2013-05-23 16:29:16
Also in:
linux-arm-kernel
Hi Madhvapathi, On Thu, May 23, 2013 at 01:49:10PM +0000, Madhvapathi Sriram wrote:
Possible mem leak here not freeing any allocated devices/memory/irq. I suggest all the error handling be collated at the end of this function for various stages and error handling be done there. Please have a look at https://www.kernel.org/doc/Documentation/input/input-programming.txt
Please note that the driver uses managed resources which get cleaned automatically. Also, could you please use a sane mailer that wraps long lines properly. Thanks. -- Dmitry