Thread (3 messages) 3 messages, 2 authors, 2013-04-17

Re: [PATCH v2] HID: appleir: add support for Apple ir devices

flat view

From: Oliver Neukum <hidden>
Date: 2013-04-17 10:30:05
Also in: lkml

On Wednesday 17 April 2013 11:03:09 Benjamin Tissoires wrote:
quoted hunk ↗ jump to hunk
+static void appleir_remove(struct hid_device *hid)
+{
+       struct appleir *appleir = hid_get_drvdata(hid);
+       del_timer_sync(&appleir->key_up_timer);
+       hid_hw_stop(hid);
+       kfree(appleir);
+}
Hi,

this looks like a race condition. If you get input between
del_timer_sync() and hid_hw_stop() the timer may be restarted.
You need to stop the hw first.

	Regards
		Oliver
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help