On Wed, Mar 20, 2013 at 8:11 AM, Mathieu Poirier
[off-list ref] wrote:

On 13-03-18 06:44 PM, Arve Hjønnevåg wrote:

quoted

On Sat, Mar 16, 2013 at 10:14 AM,  [off-list ref] wrote:

quoted

From: "Mathieu J. Poirier" <mathieu.poirier@linaro.org>

Some devices have too few buttons, which it makes it hard to have
a reset combo that won't trigger automatically.  As such a
timeout functionality that requires the combination to be held for
a given amount of time before triggering is introduced.

If a key combo is recognized and held for a 'timeout' amount of time,
the system triggers a reset.

The code seems to only require one of the keys in the combo to be held
for the full 'timeout' amount of time:

...

quoted

                /* key release */
-               if (--state->reset_seq_cnt == 0)
+               if (--state->reset_seq_cnt == 0) {
                        state->reset_canceled = false;
+                       del_timer(&state->keyreset_timeout);
+               }

I think the case you are referring to is when keys are released - please
correct me if I'm wrong.

You are correct, after the timer has been initialised (meaning that
_all_ the keys have been pressed) only a single key need to be held down
to carry out the reset order.

The current keyreset driver works exactly the same way - I just tried it
on my board.

Get back to me if you want to see this corrected.

Since this feature so far has only been used with a single key, fixing
the code is not a high priority. However, I don't think the current
description matches the implementation you have, so one of them should
change.

-- 
Arve Hjønnevåg
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html